Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure JSImport/JSExport generators to share more code and utilize more Microsoft.Interop.SourceGeneration shared code #107769

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
+1,315 −1,413
Open

Restructure JSImport/JSExport generators to share more code and utilize more Microsoft.Interop.SourceGeneration shared code #107769

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
aae7145
Use pattern matching to make the giant switch statement cleaner.
jkoritzinsky Sep 11, 2024
fdef132
Replat the JS generators to use the same stub generators as LibraryIm…
jkoritzinsky Sep 12, 2024
2d39ced
Emit initialization and fix MarshalerType handling for non-generic Task
jkoritzinsky Sep 12, 2024
7e5a1d5
Update code snippet
jkoritzinsky Sep 12, 2024
e8b8a6c
Stackalloc the marshaller arguments in the local function. Let's see …
jkoritzinsky Oct 17, 2024
d4e4214
Don't try to calculate the array size, let the compiler do it.
jkoritzinsky Oct 17, 2024
3cd828e
WithRankSpecifiers is on the array type
jkoritzinsky Oct 17, 2024
456bb73
Fix expected syntax.
jkoritzinsky Oct 18, 2024
b966264
Merge branch 'main' of https://github.com/dotnet/runtime into js-gene…
jkoritzinsky Jan 29, 2025
fe1e1b6
Add another test
jkoritzinsky Jan 30, 2025
bad0406
Fall back from sync task resolution to async task resolution if the t…
jkoritzinsky Jan 31, 2025
672327c
Treat retval as return-swapped out like we do with PreserveSig
jkoritzinsky Jan 31, 2025
e07a685
Don't re-initialize the unmanaged return value representation.
jkoritzinsky Jan 31, 2025
337bb67
Update src/libraries/System.Runtime.InteropServices.JavaScript/gen/JS…
jkoritzinsky Jan 31, 2025
db6246a
Revert change to JS side
jkoritzinsky Jan 31, 2025
c751e8e
Merge branch 'js-generator-shared-code' of https://github.com/jkoritz…
jkoritzinsky Jan 31, 2025
7595b58
Always call initialize and make sure to initialize the exception and …
jkoritzinsky Jan 31, 2025
abee68b
We need both initializers to satisfy C#
jkoritzinsky Jan 31, 2025
6c948f7
Fix DateTimeOffset marshalling
jkoritzinsky Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
399 changes: 204 additions & 195 deletions ...s/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/libraries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ internal static class Constants

public const string JSFunctionSignatureGlobal = "global::System.Runtime.InteropServices.JavaScript.JSFunctionBinding";
public const string JSMarshalerArgumentGlobal = "global::System.Runtime.InteropServices.JavaScript.JSMarshalerArgument";
public const string JSMarshalerArgument = "System.Runtime.InteropServices.JavaScript.JSMarshalerArgument";
public const string ModuleInitializerAttributeGlobal = "global::System.Runtime.CompilerServices.ModuleInitializerAttribute";
public const string CompilerGeneratedAttributeGlobal = "global::System.Runtime.CompilerServices.CompilerGeneratedAttribute";
public const string DynamicDependencyAttributeGlobal = "global::System.Diagnostics.CodeAnalysis.DynamicDependencyAttribute";
Expand Down
236 changes: 0 additions & 236 deletions .../System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSExportCodeGenerator.cs
View file
Open in desktop

This file was deleted.

Loading
Loading