[release/9.0] Test only change - Ensure we create new RemoteInvokeOptions for every call #107875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
ericstj
changed the title
artl93
approved these changes
Sep 16, 2024
|
why no build? |
The RemoteInvokeOptions instance is mutated by RemoveExecutor.Invoke and cannot be shared.
ericstj
force-pushed
the
backport/pr-107820-to-release/9.0
branch
from
53dfb2b
to
fe91fa6
Compare
|
/ba-g The CI failure is unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107820 to release/9.0
/cc @ericstj
Customer Impact
This fixes a test reliability issue that was being encountered regularly in the JITStress and PGO pipelines. Our test was sharing a static options value between multiple tests and that value could be changed by another test running which would cause the service run to be registered with the wrong commandline - resulting in the test hanging or failing.
Regression
Bug has existed in the tests since introduced
Testing
Never had a repro of the test failure, but the fix is straightforward and covered by existing tests.
Risk
Low - test only change.
Marking as approved since this is a test-only change.