Delete FEATURE_STUBS_AS_IL define #108048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
jkotas
commented
Sep 20, 2024
3 tasks
jkotas
force-pushed
the
FEATURE_STUBS_AS_IL
branch
from
21865ee to
69413fe
Compare
jkotas
force-pushed
the
FEATURE_STUBS_AS_IL
branch
from
69413fe to
b810c3c
Compare
jkotas
commented
Sep 20, 2024
| @@ -1235,6 +1236,49 @@ _GenericCLRToCOMCallStub@0 proc public | |||
| ret | |||
|
|
|||
| _GenericCLRToCOMCallStub@0 endp | |||
|
|
|||
| _GenericComCallStub@0 proc public | |||
There was a problem hiding this comment.
This ~20 instruction asm stub is a replacement for the several hundred lines of stub linker code that I am deleting. I have verified that this path is executed by (multiple) tests.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
force-pushed
the
FEATURE_STUBS_AS_IL
branch
from
e91f3f9 to
e21848a
Compare
jkoritzinsky
approved these changes
Sep 20, 2024
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
force-pushed
the
FEATURE_STUBS_AS_IL
branch
from
1bbfaaa to
3ef22c0
Compare
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g infrastructure timeout |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Delete FEATURE_STUBS_AS_IL define * Delete x86-specific GenericComCallStub * Implement GenericComCallStub
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.