Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statics issue by using data dependencies #108309

Conversation

davidwrighton
Copy link
Member

A data dependency approach for fixing issue #105441

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 27, 2024
@jkotas
Copy link
Member

jkotas commented Sep 27, 2024

This will fix the specific crash, but I do not think it is the 100% correct fix for the problem.

Our memory model guarantees that all static constructor side-effects are observable. I think that this fix only guarantees visibility of observable side-effects for statics of the given type.

@jkotas
Copy link
Member

jkotas commented Sep 27, 2024

I do not think it is the 100% correct fix for the problem.

This was also discussed in #81151 (comment) . #105832 added the barriers to JITed code, but we have missed that the barriers need to be in the asm and JIT helpers as well.

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants