Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Dispose Xunit ToolCommand - follow up #108387

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 30, 2024

Addressing @maraf's feedback from #108319.

  • whitespace
  • removal of redundant project dir setup
  • discussion: will sharing the ToolCommand have any negative impact on the tests?

@ilonatommy ilonatommy merged commit 68d8478 into dotnet:main Oct 1, 2024
22 of 24 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Oct 3, 2024
lambdageek pushed a commit to lambdageek/runtime that referenced this pull request Oct 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants