Update stepping through MulticastDelegate under the Debugger #108414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @mangod9 |
Member
Author
|
contributes to #68018 |
jkotas
reviewed
Sep 30, 2024
3 tasks
jkotas
reviewed
Oct 1, 2024
huoyaoyuan
reviewed
Oct 1, 2024
mikelle-rogers
force-pushed
the
dev/mirogers/testingMulticastDelegateMac
branch
from
e7b864f to
bcc0cf9
Compare
jkotas
reviewed
Oct 2, 2024
Member
|
The VM side of the change LGTM. I do not understand the debugger side well enough to sign-off on it. |
noahfalk
reviewed
Oct 2, 2024
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
Nice to see it coming along!
mikelle-rogers
force-pushed
the
dev/mirogers/testingMulticastDelegateMac
branch
from
f5f3709 to
c152b10
Compare
jkotas
reviewed
Oct 3, 2024
noahfalk
reviewed
Oct 8, 2024
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
A few small suggestions, but overall looks good 👍
AaronRobinsonMSFT
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the Debugger steps through a multicast delegate. Rather than putting a breakpoint on the entry of a helper method, we now call the helper method, which calls the relevant functions to find where we are to step next.