Update System.Formats.Nrbf ref sources and restore package description #108430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhandley
added
binaryformatter-migration
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Tagging subscribers to 'binaryformatter-migration': @adamsitnik, @bartonjs, @jeffhandley, @terrajobst |
3 tasks
buyaa-n
reviewed
Oct 1, 2024
src/libraries/System.Formats.Nrbf/src/System.Formats.Nrbf.csproj
Outdated
Show resolved
Hide resolved
buyaa-n
approved these changes
Oct 1, 2024
ericstj
approved these changes
Oct 1, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11137272638 |
4 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 3, 2024
dotnet#108430) * Restore System.Formats.Nrbf package description alongside package README * Add missing struct members to ref source * Update ref to match dotnet msbuild /t:GenerateReferenceAssemblySource * Remove 'EnableDefaultPackageReadmeFile' since 'true' is the default
lambdageek
pushed a commit
to lambdageek/runtime
that referenced
this pull request
Oct 3, 2024
dotnet#108430) * Restore System.Formats.Nrbf package description alongside package README * Add missing struct members to ref source * Update ref to match dotnet msbuild /t:GenerateReferenceAssemblySource * Remove 'EnableDefaultPackageReadmeFile' since 'true' is the default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Mark the System.Formats.Nrbf assembly as [Experimental] with SYSLIB5005 (#107905), the System.Formats.Nrbf package description was removed entirely rather than being shortened. This restores the short package description that is used in tooling when the full package README isn't displayed.
I also found the ref source for System.Formats.Nrbf and System.Reflection.Metadata was out of sync. It looks like the files were hand-edited and there were a few details missing along with inconsistencies compared to what
dotnet msbuild /t:GenerateReferenceAssemblySourcegenerates.The intention is to make these corrections for .NET 9, backporting to
release/9.0after merged to main.