Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate SpawnBrowserAsync issue by adding debugging. #108440

Closed
wants to merge 4 commits into from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 1, 2024

When investigating #107771, more debugging would be useful. What's more, switching it on in the PR aiming to fix the issue revealed 0 hit count. It is not a proper fix but it's probable that it will decrease the hit count on main and can be treated as a temporary measure.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Oct 1, 2024
@ilonatommy ilonatommy requested a review from pavelsavara October 1, 2024 12:59
@ilonatommy ilonatommy self-assigned this Oct 1, 2024
@ilonatommy ilonatommy requested a review from maraf as a code owner October 1, 2024 12:59
@ilonatommy ilonatommy requested a review from lewing October 1, 2024 13:00
@ilonatommy ilonatommy changed the title Decrease the hit count of SpawnBrowserAsync issue by adding debugging. Investigate SpawnBrowserAsync issue by adding debugging. Oct 1, 2024
@pavelsavara
Copy link
Member

Does that increase logging ? Could you please attach example of the log it produces ?
Are we able to capture the log from CI too ?

@ilonatommy
Copy link
Member Author

ilonatommy commented Oct 2, 2024

Does that increase logging ? Could you please attach example of the log it produces ? Are we able to capture the log from CI too ?

Here we have a log with only pw:browser, without the protocol: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-17e567dc36914e5798/Workloads-NoWebcil-ST-Wasm.Build.Tests.WasmTemplateTests/1/console.9c7b17ec.log?helixlogtype=result.
{7C7F2DA9-AC26-480E-8574-9C26474369BB}

Adding protocol as well was suggested by Playwright team.

Edit:
here we have a log with both: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-108440-merge-224a492c411e448eae/Workloads-ST-Wasm.Build.NativeRebuild.Tests.FlagsChangeRebuildTests/1/console.05ce4e89.log?helixlogtype=result
I don't see any lines added by pw:protocol or pw:browser in this PR. It might be caused by old pw used here, so merging with main. Thanks for asking about that!

@ilonatommy ilonatommy closed this Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants