Move more helpers from DomainAssembly to Assembly #108568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
am11
force-pushed
the
feature/domainassembly
branch
5 times, most recently
from
4a919da
to
d03738f
Compare
am11
force-pushed
the
feature/domainassembly
branch
7 times, most recently
from
8a6f881
to
3c066d8
Compare
am11
force-pushed
the
feature/domainassembly
branch
2 times, most recently
from
6be613e
to
e067319
Compare
am11
commented
Oct 7, 2024
| RegisterWithHostAssembly(); | ||
| } | ||
|
|
||
| void Assembly::RegisterWithHostAssembly() |
There was a problem hiding this comment.
Since some of these are only used within assembly.cpp, they can be marked static and removed from the header file (in a later PR).
am11
force-pushed
the
feature/domainassembly
branch
2 times, most recently
from
76f5e28
to
51a84a8
Compare
am11
force-pushed
the
feature/domainassembly
branch
from
5896999
to
8124caf
Compare
|
innerloop timeout is dotnet/dnceng#3879. |
|
/ba-g per #108568 (comment) innerloop timeout is known. It is incorrectly shown as still running in GitHub checks. |
|
@elinor-fung, thank you. BTW, I have the next change ready on top of this branch which deletes DomainAssembly: main...am11:runtime:feature/domainassembly2. I kept them separate, because diffs were getting a bit confusing. 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #104590