-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Merge RC2 changes into 9.0 #108677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve performance when getting parts from a package
Previously this comparison was Ordinal after calling ToUpperInvariant This was changed to InvariantIgnoreCase which breaks because it will treat things like ß and ss as equal where they were not before.
We can remove every extra field in one go, instead of removing them one by one.
Validate performance counter data to avoid excessive looping and memory consumption.
…l TFMs Marvin is the string hashing used in modern .NET; this change extends this behaviour to `string` keys when used with `MemoryCache` - noting that in many scenarios we *expect* the key to be a `string` (even though other types are allowed).
**NO MERGE** This needs to be retargeted to RC2 once that branch is created. Forward port of .NETFramework fix. Improve performance when getting parts from a package Fix regression in ExtensionEqualityComparer Previously this comparison was Ordinal after calling ToUpperInvariant This was changed to InvariantIgnoreCase which breaks because it will treat things like ß and ss as equal where they were not before. ---- #### AI description (iteration 1) #### PR Classification Performance improvement #### PR Summary This pull request improves the performance of sorting parts in the packaging system by optimizing the sorting algorithm and data structures used. - `Package.cs`: Replaced the existing dictionary with a sorted array and dictionary combination for better performance and added a new method `CopyPartDictionaryToPartList`. - `ZipPackage.cs`: Replaced `SortedSet` with a `Dictionary` for managing `ZipPackagePartPiece` and updated related methods to use the new data structure.
…otnet#108018) Developers, often in tests, rely on seeded Random instances producing the same sequence of values on every use. We made a change in .NET 9, though, that changed the sequence GetItems produces, due to employing a different algorithm. This fixes that special-case to only be used when the developer couldn't rely on the results being deterministic, namely when using either `new Random()` or `Random.Shared`. If a seed is provided or if a custom derived implementation is used, it falls back to the old behavior. Co-authored-by: Stephen Toub <stoub@microsoft.com>
…8025) * Fix custom icu fingerprinting. * fix * Update src/mono/browser/runtime/loader/icu.ts Co-authored-by: Pavel Savara <pavelsavara@microsoft.com> --------- Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
…108091) * dont try to capture threadId for NativeAOT * add config to capture bgc threadid --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
mmitche
approved these changes
Oct 8, 2024
4 tasks
steveharter
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PerformanceCounter validation changes look good.
bartonjs
approved these changes
Oct 8, 2024
This was referenced Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the changes from RC2 into the GA branch. There were no conflicts, but we should double check that everything is in order (
especially dependency versionsconfirmed).NO SQUASH - MERGE commit