Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] [browser] Make boot json file name configurable #108708

Merged
merged 6 commits into from
Oct 11, 2024
Merged

[release/9.0] [browser] Make boot json file name configurable #108708

merged 6 commits into from
Oct 11, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Oct 9, 2024

Backport of #108281 to release/9.0

/cc @lewing @maraf

Customer Impact

  • Customer reported
  • Found internally

A late customer (Uno) "feature" request. The default value of "blazor.boot.json" is a relic from SDK migration but changing it or having it configurable was no priority until Uno started to use our build system.

Regression

  • Yes
  • No

Testing

Automated. We have a lot of tests in runtime repository and SDK repository to cover correct placement and content of boot config.

Risk

Low. Based on amount of test we have and the fact that default values remain unchanged.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Oct 9, 2024
@maraf maraf added this to the 9.0.0 milestone Oct 9, 2024
@maraf maraf changed the title [browser] Make boot json file name configurable [release/9.0] [browser] Make boot json file name configurable Oct 9, 2024
@lewing lewing added the Servicing-consider Issue for next servicing release review label Oct 9, 2024
lewing
lewing requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@lewing lewing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the current form this will break the sdk tests, please stage a fix for that. I would still like to take this but lets have everything ready first.

@lewing lewing removed the Servicing-consider Issue for next servicing release review label Oct 10, 2024
@build-analysis build-analysis bot mentioned this pull request Oct 10, 2024
Open
3 tasks
@maraf maraf added the Servicing-consider Issue for next servicing release review label Oct 10, 2024
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 10, 2024
@jeffschwMSFT
Copy link
Member

@maraf can you take a look at the pr failures?

@maraf
Copy link
Member Author

maraf commented Oct 11, 2024

All green now

@jeffschwMSFT jeffschwMSFT merged commit 870e466 into dotnet:release/9.0 Oct 11, 2024
10 of 14 checks passed
This was referenced Oct 11, 2024
Open
Open
@maraf maraf deleted the BrowserBootConfigFileName90 branch October 11, 2024 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing lewing approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@maraf @jeffschwMSFT @lewing @ilonatommy @leecow