Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle building host test assets with stabilized package versions #109020

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

elinor-fung
Copy link
Member

Host test assets are built against the live runtime build, such that the live runtime version is written into their runtimeconfig.json files. The tests are run using a .NET install layout created via the PublishToDisk target for Microsoft.NETCore.App.Bundle.bundleproj. With stabilized package versions, these ended up with two different versions - the test assets had a version that still included the version suffix (for example, -ci) while the install layout had the stable version without a suffix.

We were relying on the Version property in both cases. However, that is computed differently for non-shipping (like the test assets) versus shipping (like the install layout) projects, such that with stabilized package versions, non-shipping assets still had the version suffix while shipping assets did not. This change updates the host test assets build to explicitly check for stabilized package versions and use the ProductVersion property (which has no suffixes) in that case.

See #108994. We will need to backport to fix the tests in 9.0.

cc @dotnet/appmodel @AaronRobinsonMSFT

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Oct 18, 2024
@elinor-fung elinor-fung merged commit be5bbca into dotnet:main Oct 18, 2024
71 checks passed
@elinor-fung elinor-fung deleted the host-tests-stable-version branch October 18, 2024 20:32
@elinor-fung
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11410617691

@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants