Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Handle building host test assets with stabilized package versions #109031

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle building host test assets with stabilized package versions
elinor-fung authored and github-actions committed Oct 18, 2024
commit cc48bcb3b5efd14f3825b5052c5a48046695b593
9 changes: 8 additions & 1 deletion src/installer/tests/Assets/Projects/Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -12,8 +12,15 @@
<Target Name="UpdateRuntimeFrameworkVersion"
Condition="'$(UseLocalTargetingRuntimePack)' == 'true'"
AfterTargets="ResolveTargetingPackAssets">
<PropertyGroup>
<_UpdatedVersion>$(Version)</_UpdatedVersion>
<!-- When package versions are stabilized, they do not have version suffixes. Because these are
non-shipping tests assets, the Version property will still include suffixes (unlike for shipping
assets), so we explicitly use the ProductVersion (without suffixes) in the stabilized case. -->
<_UpdatedVersion Condition="'$(StabilizePackageVersion)' == 'true'">$(ProductVersion)</_UpdatedVersion>
</PropertyGroup>
<ItemGroup>
<RuntimeFramework Version="$(Version)"
<RuntimeFramework Version="$(_UpdatedVersion)"
Condition="'%(RuntimeFramework.FrameworkName)' == '$(LocalFrameworkOverrideName)'" />
</ItemGroup>
</Target>