Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debugger] Opening the inspector session can fail with other exceptions than cancellation #109063

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 21, 2024

The goal is similar to #109011.
Based on the log: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-109053-merge-02f7660120d6447d98/chrome-DebuggerTests.EvaluateOnCallFrameTests/1/console.d884ef3d.log?helixlogtype=result

A total of 1 test files matched the specified pattern.
[xUnit.net 00:49:45.27]     DebuggerTests.EvaluateOnCallFrameTests.EvaluateIndexingMultidimensional [FAIL]
  Failed DebuggerTests.EvaluateOnCallFrameTests.EvaluateIndexingMultidimensional [1 ms]
  Error Message:
   System.ArgumentException : {
  "reason": "Render process gone.",
  "__forMethod": "Inspector.detached"
}
  Stack Trace:
     at DebuggerTests.Inspector.OpenSessionAsync(Func`3 getInitCmds, String urlToInspect, TimeSpan span) in /_/src/mono/browser/debugger/DebuggerTestSuite/Inspector.cs:line 377
   at DebuggerTests.DebuggerTestBase.InitializeAsync() in /_/src/mono/browser/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 185

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3000 seconds and was killed

insp.OpenSessionAsync can fail with exceptions other than TaskCanceledException. We are extending the exception types for which we are retrying the session opening and adding fixed prefixes to exceptions, in case we had to capture them with Known Issue.

If the retry helps, then it will mitigate #108072, #108078

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Oct 21, 2024
@ilonatommy ilonatommy self-assigned this Oct 21, 2024
@ilonatommy ilonatommy requested a review from thaystg as a code owner October 21, 2024 06:33
Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy merged commit 061941a into dotnet:main Oct 21, 2024
15 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants