-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Replace a few SuppressMessage annotations with UnconditionalSuppressMessage #109186
base: release/9.0-staging
Are you sure you want to change the base?
[release/9.0-staging] Replace a few SuppressMessage annotations with UnconditionalSuppressMessage #109186
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
This will be queued up for 9.0 servicing once the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eiriktsarpalis - Please retarget this PR to the release/9.0-staging branch.
You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.
Done. |
@artl93 This is ready for Servicing now |
@carlossanlop I just realized this is still sitting open; it needs your approval and then we can merge it for February servicing. |
Backport of #109180 to release/9.0
/cc @eiriktsarpalis
Customer Impact
Fixes a customer reported regression from MAUI that manifests as as false positive linker warning when trimming a System.Text.Json application.
Regression
Introduced by #105032. A linker suppression erroneously used
SuppressMessageAttribute
instead ofUnconditionalSuppressMessageAttribute
resulting in the warning being suppressed at build time but not at publish time.Testing
Manually verified that a warning no longer emanates from the impacted member.
Risk
Low. Makes a trivial change to a linker annotation.