Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the official build to blob storage #1092

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

dagood
Copy link
Member

@dagood dagood commented Dec 20, 2019

Mock build in progress looks good: https://dev.azure.com/dnceng/internal/_build/results?buildId=463302. I iterated on this a little already, and I'm not sure this will work yet, but figure I can kick off PR validation now to get it in sooner if it does end up working. (The build ddin't publish to dotnetcli, but it validates the preparation and validation stages still work.)

For #98 (comment).

mmitche and others added 2 commits December 20, 2019 11:44
- Use the arcade publishing process to publish the installers and checksums
- Remove old blob publishing
- Calculate the product version using an always-suffixed version
- Change the blob path that we should upload to to be Runtime/<version> instead of assets/core-setup/.. to line up with the desired paths.
Use InstallerTasksAssemblyPath.

Fail fast on RuntimeNupkgFile item duplicates.

Find some more symbol packages. AllConfigurations symbol nupkgs weren't detected due to different artifact arrangement. There may be more missing, however I did this to do unblock some quick local validation so I'm including it.
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dagood
Copy link
Member Author

dagood commented Dec 20, 2019

Merging: CI issues appear to be the known ones tracked by #1097, and the files in this PR are only used in official builds. I'll keep an eye out for the official build that runs with this change to make sure this goes as expected.

@dagood dagood merged commit bd6c81a into dotnet:master Dec 20, 2019
@dagood dagood deleted the publish-dotnetcli branch December 20, 2019 21:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants