Change iOS PEM searcher to use PemEncoding.TryFindUtf8 #109564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsjones
commented
Nov 5, 2024
| internal delegate bool DerCallback(ReadOnlySpan<byte> derData, X509ContentType contentType); | ||
|
|
||
| internal static bool TryDecodePem(ReadOnlySpan<byte> rawData, DerCallback derCallback) | ||
| internal static void TryDecodePem(ReadOnlySpan<byte> rawData, Func<ReadOnlySpan<byte>, X509ContentType, bool> derCallback) |
There was a problem hiding this comment.
The return value from this method was always ignored and seemed to have no purpose any more. So it became void.
|
|
||
| namespace System.Security.Cryptography.X509Certificates | ||
| { | ||
| internal sealed partial class AppleCertificatePal : ICertificatePal | ||
| { | ||
| internal delegate bool DerCallback(ReadOnlySpan<byte> derData, X509ContentType contentType); |
There was a problem hiding this comment.
We don't need a dedicated delegate anymore with allows ref struct on Func now, so use Func.
|
/azp run runtime-extra-platforms |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 5, 2024
|
Since it's marked as Draft I just skimmed, but it looks good, conceptually. |
|
Marked as draft while I waited for CI in case I needed to make changes since I don't have iOS tests working locally. Failures from runtime-extra-platforms appear unrelated, so marked ready for review. |
bartonjs
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppleCertificatePal.TryDecodePemcan use the UTF-8 decoder. This extends outPemEnumeratorto work on UTF-8 inputs.