Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention cpio and pigz in linux-requirements doc #109681

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Mention cpio and pigz in linux-requirements doc #109681

merged 3 commits into from
Nov 10, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 10, 2024

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 10, 2024
@am11 am11 added area-Infrastructure community-contribution Indicates that the PR has been added by a community member and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 10, 2024
@am11 am11 mentioned this pull request Nov 10, 2024
Merged
@am11
Copy link
Member Author

am11 commented Nov 10, 2024

The doc already mentions eng/common/native/install-dependencies.sh, not sure if it's a good idea to maintain these lists rather than using the script as a source of truth.

akoeplinger
akoeplinger reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about removing the list but it doesn't change that often and it's easier to communicate things like optional packages etc

docs/workflow/requirements/linux-requirements.md Outdated Show resolved Hide resolved
@ViktorHofer ViktorHofer merged commit 1a23863 into dotnet:main Nov 10, 2024
13 checks passed
@am11 am11 deleted the patch-20 branch November 10, 2024 17:30
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@am11 @mikelle-rogers
Mention cpio and pigz in linux-requirements doc (dotnet#109681)
20be543 
* Mention cpio and pigz in linux-requirements doc

* More duplicates

* Alphabatize and align style
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@am11 @akoeplinger @jkoritzinsky @ViktorHofer