-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Improve startup and warmup performance for invoke by reducing emit usage #109901
base: main
Are you sure you want to change the base?
Conversation
…flectionFunctionPointers
…flectionFunctionPointers
Tagging subscribers to this area: @dotnet/area-system-reflection |
if (argLen > MaxStackAllocArgCount) | ||
object? obj; | ||
|
||
Span<object?> copyOfArgs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please declare the variables at the assignment below? I think it is a preferred style in the coreclr runtime and it makes it easier to see the actual type the "new" allocates.
@steveharter do you plan to add support for other well known signatures than the zero arg with return value and one arg with void return ones? Based on our past discussion, we would like to eventually add ones that are on startup path of common types of apps like e.g. aspnet ones. Or were these mostly just those two basic cases? |
[verifying tests]