Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude obj/cmake from codeql. #110630

Merged
merged 4 commits into from
Dec 17, 2024
Merged

exclude obj/cmake from codeql. #110630

merged 4 commits into from
Dec 17, 2024

Conversation

mangod9
Copy link
Member

@mangod9 mangod9 commented Dec 11, 2024

There are duplicate issues being created due to random directory names generated by cmake in obj/cmake

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not duplicate issues in the sense that there's no "primary" issue (outside the CMakeFiles folder) that they're duplicates of.

Instead, what should probably be done here is to suppress the specific files that we know are generating false positives. The pattern would presumably look something like:

artifacts/obj/**/CMakeFiles/**/CheckFunctionExists.c

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment justifying this suppression is inaccurate. The comment doesn't describe why this file specifically is targeted.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

.CodeQL.yml Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants