-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude obj/cmake from codeql. #110630
exclude obj/cmake from codeql. #110630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not duplicate issues in the sense that there's no "primary" issue (outside the CMakeFiles folder) that they're duplicates of.
Instead, what should probably be done here is to suppress the specific files that we know are generating false positives. The pattern would presumably look something like:
artifacts/obj/**/CMakeFiles/**/CheckFunctionExists.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment justifying this suppression is inaccurate. The comment doesn't describe why this file specifically is targeted.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
There are duplicate issues being created due to random directory names generated by cmake in obj/cmake