-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Add OutputType=Library
tests
#110731
base: main
Are you sure you want to change the base?
Conversation
OutputType=Library
tests and improvementsOutputType=Library
tests to identify active issues
OutputType=Library
tests to identify active issuesOutputType=Library
tests to identify active issues
OutputType=Library
tests to identify active issuesOutputType=Library
tests
Add wasi-based c# api scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
src/mono/wasm/testassets/EntryPoints/LibraryMode.cs:3
- [nitpick] The class name 'Test' is too generic. Consider renaming it to something more descriptive, such as 'LibraryCallbackHandler'.
public unsafe class Test
src/mono/wasm/testassets/EntryPoints/LibraryMode.cs:6
- [nitpick] The method name 'MyCallback' is too generic. Consider renaming it to something more descriptive, such as 'HandleCallback'.
public static int MyCallback()
src/mono/wasi/Wasi.Build.Tests/WasiLibraryModeTests.cs:22
- The method
LibraryModeBuildPublishRun
is now parameterized withsdk
andhasWasmAppBundle
, but there are no test cases to cover the different behaviors based on these parameters. Consider adding test cases to ensure these scenarios are tested.
[Theory]
src/mono/wasi/testassets/LibraryMode.cs:3
- [nitpick] The class name 'Test' is too generic. Consider renaming it to something more descriptive like 'LibraryModeTest'.
public unsafe class Test
please let's discuss the goals of this before we proceed further |
The use-case on browser is something like this demo https://github.com/maraf/dotnet-wasm-react. It doesn't need |
This comment was marked as resolved.
This comment was marked as resolved.
There are updated requirements in #110620 description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add also an index.html and main.js to the library mode testasset. The main.js will start the runtime and instead of calling main, it will call just the JSExport. Ideally, also run the app in the browser
Fixes #110620.