Add lock in ValidateName #110780
Merged
Add lock in ValidateName #110780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
steveharter
reviewed
Dec 27, 2024
| @@ -221,18 +221,21 @@ protected virtual void ValidateName(IComponent component, string? name) | |||
| { | |||
| ArgumentNullException.ThrowIfNull(component); | |||
|
|
|||
| if (name != null) | |||
| lock (_syncObj) | |||
There was a problem hiding this comment.
Is there a reason to add the lock when name is null?
steveharter
added
the
needs-author-action
dotnet-policy-service
bot
removed
the
needs-author-action
This was referenced Jan 9, 2025
Open
steveharter
approved these changes
Jan 14, 2025
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
Jan 24, 2025
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added lock in ValidateName function.
Lock is required because after calculating Math.Min(_siteCount, _sites!.Length) we can meet situation when _sites length might be less than calculated value and we get out of bounds exception.
Found by Linux Verification Center (linuxtesting.org) with SVACE.