Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSEncoding math overflow #110796

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix OSEncoding math overflow #110796

merged 1 commit into from
Dec 20, 2024

Conversation

MichalPetryka
Copy link
Contributor

Discovered by @GrabYourPitchforks

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 18, 2024
@GrabYourPitchforks
Copy link
Member

@MichalPetryka Could use a unit test :)

@MichalPetryka
Copy link
Contributor Author

@MichalPetryka Could use a unit test :)

I can't figure out how to get an instance of OsEncoding without reflection.

@build-analysis build-analysis bot mentioned this pull request Dec 18, 2024
Open
@tarekgh tarekgh merged commit cf4d2b0 into dotnet:main Dec 20, 2024
80 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees
No one assigned
Labels
area-System.Text.Encoding community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalPetryka @GrabYourPitchforks @tarekgh