Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn #111081

Merged
merged 7 commits into from
Jan 7, 2025
Merged

[main] Update dependencies from dotnet/roslyn #111081

merged 7 commits into from
Jan 7, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 4, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20250106.21
  • Date Produced: January 7, 2025 3:37:35 AM UTC
  • Commit: d7b0a8c4b320a592e6b81dc5a40bc724cd8b71ba
  • Branch: refs/heads/release/dev17.13

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
c9a9c58 
…103.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-3.25052.5 -> To Version 4.13.0-3.25053.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jan 4, 2025
@build-analysis build-analysis bot mentioned this pull request Jan 4, 2025
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
48e90be 
…104.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-3.25052.5 -> To Version 4.13.0-3.25054.1
This was referenced Jan 5, 2025
Open
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
0d9fa6e 
…105.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-3.25052.5 -> To Version 4.13.0-3.25055.1
@build-analysis build-analysis bot mentioned this pull request Jan 6, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
272e9e8 
…106.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-3.25052.5 -> To Version 4.13.0-3.25056.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20250…
fd61348 
…106.21

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-3.25052.5 -> To Version 4.13.0-3.25056.21
@akoeplinger
Copy link
Member

@stephentoub @jjonescz the build fails with

src/libraries/System.Private.CoreLib/src/System/IO/TextWriter.cs(863,34): error CS8987: The 'scoped' modifier of parameter 'arg' doesn't match overridden or implemented member.
src/libraries/System.Private.CoreLib/src/System/IO/TextWriter.cs(926,34): error CS8987: The 'scoped' modifier of parameter 'arg' doesn't match overridden or implemented member.

which is likely triggered by dotnet/roslyn#76296 but I don't see any scoped usage in TextWriter.cs

The only difference I can see is that the base is using params ReadOnlySpan<object?> arg while the overrides are missing the params

@jjonescz
Copy link
Member

jjonescz commented Jan 7, 2025 •
edited
Loading

which is likely triggered by dotnet/roslyn#76296

That's correct. See also fae33d2e25a where I drafted a fix for all the breaks in runtime from this I could find at the time (dotnet/roslyn#76296 (comment)).

but I don't see any scoped usage in TextWriter.cs

The only difference I can see is that the base is using params ReadOnlySpan<object?> arg while the overrides are missing the params

params means implicitly scoped. So adding scoped to the non-params override should fix the error.

@akoeplinger akoeplinger mentioned this pull request Jan 7, 2025
Merged
This was referenced Jan 7, 2025
Open
Open
@akoeplinger
Copy link
Member

/ba-g timeouts are unrelated infrastructure issues

@akoeplinger akoeplinger merged commit cce6bdf into main Jan 7, 2025
152 of 156 checks passed
@akoeplinger akoeplinger deleted the darc-main-22251ced-e3bd-4f08-bd0a-6ea92c449b5b branch January 7, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akoeplinger @jjonescz @stephentoub