Skip to content

[browser] Don't cache index.html during development #111268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[browser] Don't cache index.html during development #111268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b277b8
Incorporate changes from https://github.com/dotnet/aspnetcore/pull/59340
maraf Jan 10, 2025
54e492d
Add using
maraf Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/mono/wasm/host/DevServer/DevServerStartup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using Microsoft.Net.Http.Headers;
using Microsoft.WebAssembly.AppHost;

namespace Microsoft.WebAssembly.AppHost.DevServer;
Expand Down Expand Up @@ -67,7 +68,6 @@ public static void Configure(IApplicationBuilder app, IOptions<DevServerOptions>
ServeUnknownFileTypes = true,
});

app.UseRouting();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call was a duplicate (see line 61)

app.UseWebSockets();

if (options.OnConsoleConnected is not null)
Expand Down Expand Up @@ -100,6 +100,14 @@ public static void Configure(IApplicationBuilder app, IOptions<DevServerOptions>
{
OnPrepareResponse = fileContext =>
{
// Avoid caching index.html during development.
// When hot reload is enabled, a middleware injects a hot reload script into the response HTML.
// We don't want the browser to bypass this injection by using a cached response that doesn't
// contain the injected script. In the future, if script injection is removed in favor of a
// different mechanism, we can delete this comment and the line below it.
// See also: https://github.com/dotnet/aspnetcore/issues/45213
fileContext.Context.Response.Headers[HeaderNames.CacheControl] = "no-store";

if (options.WebServerUseCrossOriginPolicy)
{
// Browser multi-threaded runtime requires cross-origin policy headers to enable SharedArrayBuffer.
Expand Down