-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPAddress.IsValid #111433
Add IPAddress.IsValid #111433
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
{ | ||
int end = ipSpan.Length; | ||
long address = IPv4AddressHelper.ParseNonCanonical(ipStringPtr, 0, ref end, notImplicitFile: true); | ||
return address != IPv4AddressHelper.Invalid && end == ipSpan.Length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What address does IPv4AddressHelper.Invalid represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a -1 sentinel value
/ba-g build failure is dotnet/dnceng#3008 |
Closes #111282