Outbox AesGcm in to Microsoft.Bcl.Cryptography #111722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsjones
commented
Jan 22, 2025
src/libraries/Common/src/System/Security/Cryptography/AesGcm.Windows.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Bcl.Cryptography/src/buildTransitive/Microsoft.Bcl.Cryptography.targets
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/AesGcm.OpenSsl.cs
Show resolved
Hide resolved
This was referenced Jan 23, 2025
bartonjs
reviewed
Jan 27, 2025
src/libraries/Common/src/System/Security/Cryptography/AesAEAD.cs
Outdated
Show resolved
Hide resolved
|
The code refactorings LGTM; signoff withheld pending resolution of the "fail the build" target. |
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
|
Okay, .NET 10 (type forward):
.NET 9 (type forward):
.NET 8 (type forward):
.NET Framework (implementation):
.NET Standard (no
|
This was referenced Feb 14, 2025
This was referenced Feb 14, 2025
Open
bartonjs
reviewed
Feb 14, 2025
src/libraries/Common/tests/System/Security/Cryptography/AesGcmTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Feb 14, 2025
|
Failures are known and unrelated to the changes. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an implementation of
AesGcmin Microsoft.Bcl.Cryptography to allow using it in .NET Framework. If the target framework is .NET 8+, then it type-forwards to the built-in version. .NET Standard is not able to include an implementation ofAesGcmbecause it was included in .NET Standard 2.1 with an API shape that we do not want to support.Closes #89718