JIT: Ensure BBF_PROF_WEIGHT flag is set when we have PGO data
#111780
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods. |
| { | ||
| unprofiledBlocks++; | ||
| continue; | ||
| if (checkProfileFlag && (block->bbPreds != nullptr)) |
There was a problem hiding this comment.
Can you explain the exclusion for blocks with no preds?
There was a problem hiding this comment.
For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)
There was a problem hiding this comment.
Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.
|
libraries-jitstress failures are #111777 |
* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...
Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures
BBF_PROF_WEIGHTis set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.