Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed assertion 'FPbased == FPbased2' #111787

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix failed assertion 'FPbased == FPbased2' #111787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e4e8b
Move assert to prevent incorrect trigger when lvaFrameAddress optimiz…
filipnavara Jan 24, 2025
bfb4743
Better fix
filipnavara Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12311,7 +12311,7 @@ size_t emitter::emitOutputInstr(insGroup* ig, instrDesc* id, BYTE** dp)

// If there are 2 GC vars in this instrDesc, get the 2nd variable
// that should be tracked.
adr2 = emitComp->lvaFrameAddress(varNum2, &FPbased2, true);
adr2 = emitComp->lvaFrameAddress(varNum2, &FPbased2, FPbased);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to tell, but can you add a comment about suppressFPtoSPRewrite in the method docs of lvaFrameAddress? OK to do in separate PR.

ofs2Dist = EA_SIZE_IN_BYTES(size);
#ifdef DEBUG
assert(FPbased == FPbased2);
Expand Down
Loading