Fix linux-x86 build #111861
Merged
Fix linux-x86 build #111861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
This comment was marked as resolved.
This comment was marked as resolved.
jkotas
reviewed
Jan 27, 2025
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This comment was marked as resolved.
This comment was marked as resolved.
jkotas
reviewed
Jan 27, 2025
jakobbotsch
reviewed
Jan 27, 2025
This comment was marked as resolved.
This comment was marked as resolved.
am11
reviewed
Jan 27, 2025
filipnavara
commented
Jan 27, 2025
| @@ -1143,9 +1144,12 @@ VOID StubLinkerCPU::X86EmitPopRegs(unsigned regSet) | |||
| { | |||
| STANDARD_VM_CONTRACT; | |||
|
|
|||
| for (X86Reg r = NumX86Regs; r >= kEAX; r = (X86Reg)(r-1)) | |||
| for (X86Reg r = NumX86Regs; regSet > 0; r = (X86Reg)(r-1)) | |||
There was a problem hiding this comment.
This would always underflow, X86Reg is unsigned and kEAX is 0.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
filipnavara
commented
Jan 27, 2025
jkotas
approved these changes
Jan 27, 2025
jkotas
reviewed
Jan 28, 2025
3 tasks
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 28, 2025
* main: (31 commits) Fix linux-x86 build (dotnet#111861) Add FrozenDictionary specialization for integers / enums (dotnet#111886) [SRM] Refactor reading from streams. (dotnet#111323) Sign the DAC and DBI during the build process instead of in separate steps (dotnet#111416) Removing Entry2MethodDesc as it is unnecessary (dotnet#111756) Cross Product for Vector2 and Vector4 (dotnet#111265) Handle unicode in absolute URI path for combine. (dotnet#111710) Drop RequiresProcessIsolation on mcc tests (dotnet#111887) [main] Update dependencies from dotnet/roslyn (dotnet#111691) new trimmer feature System.TimeZoneInfo.Invariant (dotnet#111215) [browser] reduce msbuild memory footprint (dotnet#111751) Add debugging checks for stack overflow tests failure (dotnet#111867) Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2629821 (dotnet#111884) Bump main to preview2 (dotnet#111882) Avoid generic virtual dispatch for frozen collections alternate lookup (dotnet#108732) Bump main versioning to preview1 (dotnet#111880) Switch OneLoc to main (dotnet#111872) Improve docs on building ILVerify (dotnet#111851) Update Debian version to 13 (dotnet#111768) win32: add fallback to environment vars for system folder (dotnet#109673) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linux-x86 builds have been broken for quite a while. At some point in the .NET 5 timeframe
genZeroInitFrameUsingBlockInitwas rewritten and it dropped support for non-SIMD platforms. linux-x86 hadFEATURE_SIMDdisabled since 2016 but the original intention was to disable AVX only.This is good enough to run Hello World again.