Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke crossgen exe when building R2RTest #111881

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Invoke crossgen exe when building R2RTest #111881

merged 5 commits into from
Jan 29, 2025

Conversation

steveisok
Copy link
Member

Given the way crossgen is build in-tree, we no longer have crossgen.dll, but rather the actual crossgen executable.

Should fix #111878

@steveisok
Invoke crossgen exe when building R2RTest
2fb999e 
Given the way crossgen is build in-tree, we no longer have crossgen.dll,
but rather the actual crossgen executable.

Should fix dotnet#111878
@jkotas
Copy link
Member

jkotas commented Jan 28, 2025

The same problem exists at

runtime/eng/pipelines/coreclr/templates/crossgen2-comparison-build-job.yml

Lines 72 to 75 in f41b65f

value: $(productDirectory)$(dir)$(targetFlavor)$(dir)crossgen2$(dir)crossgen2.dll
- ${{ if ne(parameters.archType, 'x64') }}:
- name: crossgen2location
value: $(productDirectory)$(dir)$(targetFlavor)$(dir)x64$(dir)crossgen2$(dir)crossgen2.dll

@jkotas
Copy link
Member

jkotas commented Jan 28, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 28, 2025
Open
Open
Open
@steveisok
Copy link
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok steveisok merged commit d551abb into dotnet:main Jan 29, 2025
191 of 196 checks passed
@steveisok steveisok deleted the fix-clr-outerloop branch January 29, 2025 19:06
@steveisok steveisok mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@steveisok steveisok

Labels
area-Infrastructure-coreclr
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crossgen2 Comparison jobs are failing in outerloop
3 participants
@steveisok @jkotas @jkoritzinsky