Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the RID-specific System.IO.Ports packages in the VMR #112054

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

jkoritzinsky
Copy link
Member

The RID-specific System.IO.Ports packages weren't getting produced in the VMR once we did the build leg reduction as the VMR sets both BuildAllConfigurations and DotNetBuildAllRuntimePacks. Refactor how we calculate the condition and explicitly enable the packages in the VMR.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member

The RID-specific System.IO.Ports packages weren't getting produced in the VMR once we did the build leg reduction as the VMR sets both BuildAllConfigurations and DotNetBuildAllRuntimePacks

I'm not fully following. BuildAllConfigurations is a thing of the past for input control switches (except for one use case in runtimelab). I think you're referring to the -pack switch?

Can you please provide more details on how this regressed? This would help me better understand the proposed fix.

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Feb 2, 2025

When I added DotNetBuildAllRuntimePacks, I found I needed to handle the configuration of "what if you set that and pass -pack" vs "what if you don't set that and don't pass -pack", etc. And the condition didn't do what I wanted to do in the VMR (which does set that property and pass -pack).

@jkoritzinsky jkoritzinsky merged commit 6f3f675 into dotnet:main Feb 2, 2025
87 checks passed
@jkoritzinsky jkoritzinsky deleted the build-ports-native-vmr branch February 2, 2025 19:20
grendello added a commit to grendello/runtime that referenced this pull request Feb 3, 2025
* main:
  System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799)
  Keep test PDB in helix payload for native AOT (dotnet#111949)
  Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054)
  Always inline number conversions (dotnet#112061)
  Use Contains{Any} in Regex source generator (dotnet#112065)
  Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013)
  JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590)
  Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011)
  Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046)
  JIT: Compute `fgCalledCount` after synthesis (dotnet#112041)
  Simplify boolean logic in `TimeZoneInfo` (dotnet#112062)
  JIT: Update type when return temp is freshly created (dotnet#111948)
  Remove unused build controls and simplify DotNetBuild.props (dotnet#111986)
  Fix case-insensitive JSON deserialization of enum member names (dotnet#112028)
  WasmAppBuilder: Remove double computation of a value (dotnet#112047)
  Disable LTCG for brotli and zlibng. (dotnet#111805)
  JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595)
  simplify x86 special intrinsic imports (dotnet#111836)
  JIT: Try to retain entry weight during profile synthesis (dotnet#111971)
  Fix explicit offset of ByRefLike fields. (dotnet#111584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants