-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] samplepoint instrumentation into Mono profiler #112352
Draft
pavelsavara
wants to merge
14
commits into
dotnet:main
Choose a base branch
from
pavelsavara:mono_profile_safepoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+550
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Feb 10, 2025
Open
Hi @pavelsavara, |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Collect sample stack traces in the single-threaded browser.
Single threaded environment can't have dedicated thread for "stop-the-world + collect stack traces" implementation.
So we need to collect samples by instrumenting the code instead.
Previously we implemented browser based profiler which collects "sample" on every method entry/leave. In realistic application, that generates too much traffic for the browser profiler.
This enhancement could also be used to implement sampling profiler with ST diagnostic server.
Goal
samplepoint
instrumentation into Mono profiler, use the existing enter/leave too.method_enter
event/instrumentation.Implementation
MINT_PROF_SAMPLEPOINT
method_samplepoint
mini_profiler_emit_samplepoint
sampleIntervalMs
for browser profiler. 1ms by default. All samples when set to0
.call $mono_profiler_raise_method_samplepoint
append_profiler_event
calling newmono_jiterp_prof_enter
,mono_jiterp_prof_samplepoint
,mono_jiterp_prof_leave
INTERP_PROFILER_RAISE
mono_wasm_profiler_now
andmono_wasm_profiler_record
browser.c
newshould_record_frame
profiler_stack
and skip countersample_skip_counter
callspec
parametr to profiler allows to filter the instrumentation, for example by namespacecallspec=N:Sample.FooNs
Todo
Contributes to #76316