fix for possible Null Reference Exception #112412
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-xml |
| XmlNode n = LoadNode(true)!; | ||
|
|
||
| // Move to the next node | ||
| if (n.NodeType != XmlNodeType.Attribute) | ||
| if (n != null && n.NodeType != XmlNodeType.Attribute) |
There was a problem hiding this comment.
The null-forgiving operator in the previous line explicitly expressed that null shouldn't be returned in this case.
Reading through the implementation, null can only be returned in case of malformed xml (end element without starting element). In this case, the behavior should be reconsidered.
There was a problem hiding this comment.
It may be more appropriate to fix it like this then?
XmlNode? n = LoadNode(true);
Debug.Assert(n != null);
There was a problem hiding this comment.
Thanks for the tip. I used option with "Debug.Assert".
|
/ba-g unrelated timeouts due to overloaded queues |
|
Should i push this changes to other branches (release/*)? |
No. Backporting to release branches should be done by area owner. This PR doesn't have real impact and doesn't meet the criteria. |
Method "LoadNode" returns the nullable type "XmlNode?". So, maybe we need to check "n" for "null" here?
Found by Linux Verification Center (linuxtesting.org) with SVACE.