Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Use the SkipOnMonoAttribute constructor signature with optional parameter #112476

Merged

Conversation

kotlarmilos
Copy link
Member

Description

The Mono AOT compiler cannot find the SkipOnMonoAttribute constructor if the optional parameter is not provided.

Fixes #112348

@kotlarmilos kotlarmilos added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Infrastructure-mono labels Feb 12, 2025
@kotlarmilos kotlarmilos added this to the 10.0.0 milestone Feb 12, 2025
@kotlarmilos kotlarmilos self-assigned this Feb 12, 2025
@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-llvm

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@kotlarmilos
Copy link
Member Author

@kotlarmilos kotlarmilos removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Feb 12, 2025
@kotlarmilos kotlarmilos marked this pull request as ready for review February 12, 2025 19:42
@Copilot Copilot bot review requested due to automatic review settings February 12, 2025 19:42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/tests/JIT/Regression/JitBlue/Runtime_68568/Runtime_68568.il: Language not supported
@kotlarmilos kotlarmilos merged commit 98e0bbe into dotnet:main Feb 13, 2025
109 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux-x64] [mono-aot] AOT compile CoreCLR tests linux.x64.Release/JIT/Regression/Regression_2/Runtime_68568
2 participants