Host: log exception if a service factory fails #112534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
This was referenced Feb 13, 2025
steveharter
reviewed
Feb 14, 2025
Contributor
|
cc @halter73 for any feedback. Thanks |
steveharter
approved these changes
Feb 20, 2025
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
The changes look reasonable and low-risk and will help diagnose issues with configuring the services.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the host doesn't log any exception if a
IHostedServiceorIStartupValidatorservice factory fails. If you useRunAsyncyou also have no way to log it yourself since the host has already been disposed after it returns (see also #72225).This catches any exceptions thrown by the
GetServicecalls and logs and re-throws the exception, similiarly on how it is already done for exceptions inStartAsyncetc. .