Fix path to dotnet.sh in AndroidSampleApp project
#112590
Open
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/mono/sample/Android/AndroidSampleApp.csproj: Language not supported
steveisok
approved these changes
Feb 14, 2025
This was referenced Feb 15, 2025
ivanpovazan
reviewed
Feb 17, 2025
Comment on lines
19
to
20
| <RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' == 'Windows_NT'">$(RepoRoot)dotnet.cmd</RepoDotnet> | ||
| <RepoDotnet Condition="'$(RepoDotnet)' == '' and '$(OS)' != 'Windows_NT'">$(RepoRoot)dotnet.sh</RepoDotnet> |
There was a problem hiding this comment.
I don't think we need RepoDotnet property at all. We can instead just use $(DotNetTool) at line 34: https://github.com/dotnet/runtime/pull/112590/files#diff-1e632e29d3bd8c79a2aa62b91516646c9bc2bf0d2fa55089c3d4f25669e85eb0R34
and remove RepoDotnet.
DotNetTool gets properly resolved in: https://github.com/dotnet/arcade/blob/ae3c938af5df4a2db45ded37dd05608ce59d8e5e/src/Microsoft.DotNet.Arcade.Sdk/tools/RepoLayout.props#L20-L31
for Windows and non-Windows hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-Windows path was missing a
... I switched it to usingRepoRoot, since I find that clearer than the relative path from the csproj.