Reapply "[browser][MT] move wasm MT CI legs to extra-platforms (#112712)" #112716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
akoeplinger
added
area-Build-mono
and removed
needs-area-label
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml:180
- Removing the gating condition for multi-threaded builds may cause these tests to run in pipelines where they were not intended; please verify that this change is deliberate and that unintended test executions are avoided.
condition: ne(variables['wasmMultiThreadedBuildOnlyNeededOnDefaultPipeline'], true)
eng/pipelines/runtime.yml:825
- Multi-threaded library tests have been removed from runtime.yml in favor of the extra-platforms configuration; please confirm that the overall test coverage and any dependent job triggers are adjusted accordingly.
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Feb 19, 2025
pavelsavara
approved these changes
Feb 20, 2025
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g failures are unrelated |
akoeplinger
deleted the
revert-112712-revert-112690-browser_no_MT_on_runtime_pipeline
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fix that caused the runtime pipeline to not get triggered.