-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable test #112780
Disable test #112780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs:99
- [nitpick] Consider adding a comment specifying when to re-enable this test (e.g. for .NET 9.0+), so that test coverage is restored once the underlying issue is fixed.
[ActiveIssue("https://github.com/dotnet/runtime/issues/112700")]
Tagging subscribers to this area: @dotnet/ncl |
Test only change, tell mode, adding servicing approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/azp list |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
Disabling this test will have no effect about the issue, it will keep popping from some other test, because issue is on the hot path. |
I second Ahmets concern, are we sure this happens only on the test that is being disabled? |
47dd1c8
to
818c1a8
Compare
/azp run runtime |
1 similar comment
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
Disabling test failing on assert in #112700.
This is already fixed in .NET 9.0+ by #93984.
cc @wfurt @karelz
Customer Impact
Regression
Testing
CI
Risk
Very low - test only change.