Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing #112787

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[browser] add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing #112787

wants to merge 10 commits into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 21, 2025 •
edited
Loading

  • add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing
  • add dotnet.diag.js.map when FeaturePerfTracing and not publish
  • fix W.B.T.

Contributes to #76316

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm labels Feb 21, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Feb 21, 2025
@pavelsavara pavelsavara self-assigned this Feb 21, 2025
This was referenced Feb 21, 2025
Open
Open
Open
This was referenced Feb 24, 2025
Open
Closed
@pavelsavara
Copy link
Member Author

enable FeaturePerfTracing when Debug & workload/native

We would not do that because that would trigger re-link in dev inner loop for everyone, making it slower.

@pavelsavara
Merge branch 'main' into browser_diag_js
0b6b080 
# Conflicts:
#	src/mono/browser/runtime/exports-binding.ts
@pavelsavara
more
ddf4999
@pavelsavara pavelsavara marked this pull request as ready for review February 25, 2025 15:13
@Copilot Copilot bot review requested due to automatic review settings February 25, 2025 15:13
Copilot
Copilot AI reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.

maraf
maraf reviewed Feb 26, 2025
View reviewed changes
src/mono/browser/build/BrowserWasmApp.targets
@@ -3,7 +3,8 @@
<!-- Post Wasm MVP features -->
<WasmEnableExceptionHandling Condition="'$(WasmEnableExceptionHandling)' == ''">true</WasmEnableExceptionHandling>
<WasmEnableSIMD Condition="'$(WasmEnableSIMD)' == ''">$(WasmEnableExceptionHandling)</WasmEnableSIMD>
<FeaturePerfTracing Condition="'$(FeaturePerfTracing)' == '' and '$(Configuration)' == 'Debug'">true</FeaturePerfTracing>
<!-- we are not triggering FeaturePerfTracing in Debug automatically, because it would trigger re-link, making dev-loop slow -->
<FeaturePerfTracing Condition="'$(WasmProfilers)' != ''">true</FeaturePerfTracing>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is situation when user sets FeaturePerfTracing=false and WasmProfilers=... valid? Is the override of FeaturePerfTracing intentional in that case?

src/mono/browser/build/WasmApp.InTree.props
@@ -15,6 +15,7 @@
<RunAOTCompilation Condition="'$(RunAOTCompilation)' == ''">false</RunAOTCompilation>
<PublishTrimmed>true</PublishTrimmed>
<RunAnalyzers>false</RunAnalyzers>
<FeaturePerfTracing>true</FeaturePerfTracing>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it do any harm to wasi? https://github.com/dotnet/runtime/blob/main/src/mono/sample/wasm/Directory.Build.props#L39

src/mono/browser/runtime/rollup.config.js
output: [
{
format: "es",
file: nativeBinDir + "/dotnet.diag.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we want to go with shortcut diag instead of full diagnostics? With HG we also used globalization instead of eg glob

src/mono/wasm/Wasm.Build.Tests/ProjectProviderBase.cs
@@ -127,17 +134,26 @@ public IReadOnlyDictionary<string, DotNetFileName> FindAndAssertDotnetFiles(
string pattern = $"^{prefix}{s_dotnetVersionHashRegex}{extension}$";
var match = Regex.Match(actualFilename, pattern);
if (!match.Success)
{
msg.AppendLine($" FP no match expectedFilename:{expectedFilename} actualFile:{actualFile}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just me, but I'm having problems to understand what are the messages telling me.

  • FP no match ..
  • FP actual ..
  • No FP no match ..
  • No FP actual ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot to revert those.

@pavelsavara @maraf
Update src/mono/wasm/Wasm.Build.Tests/DiagnosticsTests.cs
4f67aef 
Co-authored-by: Marek Fišera <mara@neptuo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf left review comments

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf