Delete unused legacy hosting flags #112975
Open
+10
−386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
|
Tagging subscribers to this area: @mangod9 |
jkotas
commented
Feb 27, 2025
| // Fortunately, we should never get into this case, since the thread flag about | ||
| // ignoring unhandled exceptions cannot be set on the default domain. | ||
|
|
||
| BOOL fIsProcessTerminating = !(AppDomain::GetCurrentDomain()->IgnoreUnhandledExceptions()); |
There was a problem hiding this comment.
This functionality is superseded by #101560
huoyaoyuan
reviewed
Feb 27, 2025
| STARTUP_LOADER_OPTIMIZATION_MASK = 0x3<<1, // loader optimization mask | ||
| STARTUP_LOADER_OPTIMIZATION_SINGLE_DOMAIN = 0x1<<1, // no domain neutral loading | ||
| STARTUP_LOADER_OPTIMIZATION_MULTI_DOMAIN = 0x2<<1, // all domain neutral loading | ||
| STARTUP_LOADER_OPTIMIZATION_MULTI_DOMAIN_HOST = 0x3<<1, // strong name domain neutral loading |
There was a problem hiding this comment.
There is LoaderOptimizationAttribute specifying these flags. Now all the flags are deprecated, should the attribute be considered for deprecation?
There was a problem hiding this comment.
Possibly. I think you can find number of attribute types that were added for compatibility with .NET Framework and that have no effect in .NET Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.