[browser] rename WasmPerfTracing #113222
Merged
[browser] rename WasmPerfTracing #113222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
requested review from
maraf,
ilonatommy,
lewing and
akoeplinger
as code owners
There was a problem hiding this comment.
PR Overview
This PR renames the property and related references from "FeaturePerfTracing" to "WasmPerfTracing" to provide a more accurate naming convention in the browser-related code.
- Renamed property in BuildOptions, MSBuildOptions, PublishOptions, and related test and task files.
- Updated environment variable references in rollup and ES6 library files to match the new naming.
Reviewed Changes
| File | Description |
|---|---|
| src/mono/wasm/Wasm.Build.Tests/BrowserStructures/BuildOptions.cs | Renamed property from FeaturePerfTracing to WasmPerfTracing |
| src/mono/wasm/Wasm.Build.Tests/WasmSdkBasedProjectProvider.cs | Updated property reference for WasmPerfTracing |
| src/mono/wasm/Wasm.Build.Tests/BrowserStructures/MSBuildOptions.cs | Renamed property to WasmPerfTracing |
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs | Renamed property and updated parameter usage |
| src/mono/wasm/Wasm.Build.Tests/DiagnosticsTests.cs | Updated constructor call to use WasmPerfTracing |
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs | Renamed property and updated related method calls |
| src/mono/browser/runtime/rollup.config.js | Updated environment variable check from FEATURE_PERFTRACING to WASM_PERFTRACING |
| src/mono/browser/runtime/es6/dotnet.es6.lib.js | Updated environment variable check and usage for WasmPerfTracing |
| src/mono/wasm/Wasm.Build.Tests/BrowserStructures/PublishOptions.cs | Renamed property from FeaturePerfTracing to WasmPerfTracing |
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs | Renamed parameter from featurePerfTracing to wasmPerfTracing in candidate filtering |
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/mono/browser/runtime/es6/dotnet.es6.lib.js:93
- There is a duplicate key for 'enablePerfTracing' in the postset string; please review if the second occurrence should use a different key or be removed to avoid conflicting configuration.
`enablePerfTracing: ${ENABLE_BROWSER_PROFILER ? "true" : "false"}, ` +
|
/ba-g CI timeout |
lewing
reviewed
Mar 7, 2025
| @@ -87,7 +87,7 @@ function injectDependencies() { | |||
| DotnetSupportLib["$DOTNET__postset"] = `DOTNET.setup({ ` + | |||
| `wasmEnableSIMD: ${WASM_ENABLE_SIMD ? "true" : "false"},` + | |||
| `wasmEnableEH: ${WASM_ENABLE_EH ? "true" : "false"},` + | |||
| `enablePerfTracing: ${FEATURE_PERFTRACING ? "true" : "false"}, ` + | |||
| `enablePerfTracing: ${WASM_PERFTRACING ? "true" : "false"}, ` + | |||
There was a problem hiding this comment.
is enablePerfTracing being set twice?
There was a problem hiding this comment.
thank you, it should be set when ENABLE_BROWSER_PROFILER or WASM_PERFTRACING
I will address it in next EP PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not trigger re-link for unit tests.
The default
FeaturePerfTracingis false for the runtime pack.The unit tests set it to true in
src\tests\Directory.Build.targets->clr.featuredefines.propsThis PR will disconnect them.
Contributes to #113025