Bring up runtime-diagnostics pipeline #113257
Open
+321
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/azp run runtime-diagnostics |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
ba8acbd to
0281dde
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
0281dde to
930997a
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
930997a to
ec732bf
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
ec732bf to
1e8f6bd
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
1e8f6bd to
1dde023
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
This was referenced Mar 7, 2025
Open
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
901b3fa to
a44da84
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines failed to run 1 pipeline(s). |
steveisok
force-pushed
the
extend-diag-pipeline
branch
from
a44da84 to
cf0c9ca
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a pipeline for manually triggering runtime diagnostics builds and tests for runtime PRs.
- Added a new YAML template (runtime-diag-job.yml) defining the diagnostic job steps.
- Updated the runtime-diagnostics.yml to incorporate the new diagnostics job into the platform matrix and remove scheduled triggers.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/diagnostics/runtime-diag-job.yml | Introduces a new job template with parameters and well-defined build/test steps for runtime diagnostics. |
| eng/pipelines/runtime-diagnostics.yml | Integrates the new diagnostics job into the diagnostics pipeline via platform matrix templates. |
Comments suppressed due to low confidence (2)
eng/pipelines/diagnostics/runtime-diag-job.yml:59
- There is an inconsistency in the naming of the OS subgroup parameter; it is declared as 'osSubgroup' (line 8) but referenced as 'osSubGroup' here. Consider updating it to maintain consistent casing.
name: Logs_Build_Attempt$(System.JobAttempt)_${{ parameters.osGroup }}_${{ parameters.osSubGroup }}_${{ parameters.archType }}_${{ parameters.buildConfig }}_${{ parameters.name }}
eng/pipelines/diagnostics/runtime-diag-job.yml:72
- The condition compares array parameters to an empty string, which may not work as expected. Consider checking if the arrays are empty by evaluating their length instead.
${{ if or(ne(parameters.dependsOn,''), ne(parameters.dependsOnGlobalBuilds,'')) }}:
max-charlamb
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to allow any runtime PR that may impact diagnostics to manually trigger a pipeline that runs the runtime->diagnostics build / test.
The yml is probably a bit duplicative, but the intent is to keep it simple.