[wasm] initial build of coreclr.runtime #113429
Conversation
|
Tagging subscribers to this area: @hoyosjs |
| @@ -10181,6 +10181,8 @@ void MethodTableBuilder::CheckForSystemTypes() | |||
| // although applying 16 byte alignment is consistent with treatment of 128 bit SSE types | |||
| // even on X86 | |||
| pLayout->m_ManagedLargestAlignmentRequirementOfAllMembers = 16; // sizeof(__int128) | |||
| #elif defined(TARGET_WASM) | |||
There was a problem hiding this comment.
This looks equivalent to the previous #elif, any reason for having it separate?
There was a problem hiding this comment.
Not really, it is just that I would need to update the comment and I am also not sure if it is the final value. I don't know yet if we will need 16 bytes alignment for v128. It looks like 4 might be enough and 8 for int128 which is represented as structure of 2x int64 in wasm.
| // Be sure to rebuild clr/src/vm/ceemain.cpp after changing this file, to | ||
| // ensure that the constants match the expected C/C++ values | ||
|
|
||
| #define DynamicHelperFrameFlags_ObjectArg 1 |
There was a problem hiding this comment.
Where is this needed? These constants are used only by asm helpers.
There was a problem hiding this comment.
I hit it here
src/coreclr/vm/frames.cpp:1028:37: error: use of undeclared identifier 'DynamicHelperFrameFlags_ObjectArg'
1028 | if (m_dynamicHelperFrameFlags & DynamicHelperFrameFlags_ObjectArg)
Maybe I should disable FEATURE_READYTORUN. That would need more changes though IIRC.
No description provided.