[CI run only] Use funclets and new EH on win-x86 #113576
Draft
+757
−410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 |
filipnavara
force-pushed
the
x86funclets
branch
from
76b09d2 to
024b6e8
Compare
filipnavara
force-pushed
the
x86funclets
branch
from
c9aa055 to
550dec6
Compare
…RE_EH_FUNCLETS is not always updated and cannot be relied on
3 tasks
This was referenced Mar 20, 2025
filipnavara
force-pushed
the
x86funclets
branch
from
7f861f9 to
dab5033
Compare
|
Since some people are watching... Nearly all libraries test pass and CoreCLR test failures are well understood - shortcuts taken in P/Invoke implementation don't handle SuppressGCTransition correctly; x86 has no native code unwind which triggers one of the asserts due to the initial context state; etc. I'll keep this open for a little longer to clean up the remaining issues. I'll file PRs for things that should be fixed regardless (JIT issues, stack unwinding issues affecting linux-x86, etc.). I'll post some experiment summary once things settle down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for review, move on.