-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable ClientDisableTlsResume_Succeeds test #113604
Reenable ClientDisableTlsResume_Succeeds test #113604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables the ClientDisableTlsResume_Succeeds test to verify that the previously reported issue has been resolved.
- Re-enabled the TLS resume test by removing the ActiveIssue attribute
- Confirms support for running the test on Windows
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/ba-g The affected test did not fail, other failures are unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It feels like the test was flaky for some reason but I'm fine enabling it again. If this fails again perhaps we can run it isolation e.g. no parallel or we would need to investigate deeper.
I ran the test locally in a loop for couple of hours and could not reproduce the failure anymore. This PR reenables the test to see if the (external) issue is resolved.
Closes #103449.