Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable ClientDisableTlsResume_Succeeds test #113604

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Mar 17, 2025

I ran the test locally in a loop for couple of hours and could not reproduce the failure anymore. This PR reenables the test to see if the (external) issue is resolved.

Closes #103449.

@Copilot Copilot bot review requested due to automatic review settings March 17, 2025 08:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables the ClientDisableTlsResume_Succeeds test to verify that the previously reported issue has been resolved.

  • Re-enabled the TLS resume test by removing the ActiveIssue attribute
  • Confirms support for running the test on Windows

@rzikm
Copy link
Member Author

rzikm commented Mar 18, 2025

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Mar 19, 2025

/ba-g The affected test did not fail, other failures are unrelated

@rzikm rzikm requested a review from a team March 19, 2025 12:33
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It feels like the test was flaky for some reason but I'm fine enabling it again. If this fails again perhaps we can run it isolation e.g. no parallel or we would need to investigate deeper.

@rzikm rzikm merged commit 230a4ce into dotnet:main Mar 19, 2025
112 of 127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI
2 participants