JIT: Remove oldlayout test configs #113621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanasifkhalid
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete references to "jitoldlayout" from test configuration files as the old layout implementation is no longer in use.
- Removed "jitoldlayout" from the run-test-job configuration
- Removed "jitoldlayout" from the libraries-pgo configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/common/templates/runtimes/run-test-job.yml | Removed obsolete "jitoldlayout" test configuration |
| eng/pipelines/coreclr/libraries-pgo.yml | Eliminated unused "jitoldlayout" entry from PGO pipelines |
amanasifkhalid
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Mar 17, 2025
jakobbotsch
reviewed
Mar 17, 2025
src/coreclr/ilasm/CMakeLists.txt
Outdated
|
|
||
| # Ensure secure source code hashing is enabled when building asmparse.cpp | ||
| # to avoid BinSkim BA2004 warnings. | ||
| set_source_files_properties( prebuilt/asmparse.cpp PROPERTIES COMPILE_FLAGS "/ZH:SHA_256" ) |
There was a problem hiding this comment.
Yeah, must've got caught in my git stash. Thanks
|
/ba-g unrelated test failures |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #113335. There is no longer any old layout implementation to test.
@dotnet/jit-contrib PTAL, thanks!