ML-KEM: OpenSSL Part 1 #113719

vcsjones · 2025-03-20T01:13:21Z

This brings in the minimum implementation to have a testable implementation of ML-KEM on Linux.

What is in this PR:

Key generation
Key import (seed, encapsulation key, decapsulation key)
Key export (seed, encapsulation key, decapsulation key)
Encapsulate and Decapsulate
Microsoft.Bcl.Cryptography (only working implementation for now is type-forwards, down level always has IsSupported as false until a Windows implementation is available)
Tests

What is not in this PR:

PKCS8 / SPKI loading and export
Convenience APIs, Callee-allocated buffers
Platform-specific derived types (MLKemOpenSsl, etc)
Certificates

Contributes to #113508

...libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EVP.KemAlgs.cs

src/libraries/Common/tests/System/Security/Cryptography/ByteUtils.cs

src/libraries/Common/src/System/Security/Cryptography/MLKem.cs

src/libraries/Microsoft.Bcl.Cryptography/src/Resources/Strings.resx

src/libraries/System.Security.Cryptography/src/Resources/Strings.resx

src/libraries/Common/src/System/Security/Cryptography/MLKem.cs

src/libraries/Common/tests/System/Security/Cryptography/MLKemTests.Encapsulation.cs

src/libraries/Common/tests/System/Security/Cryptography/MLKemTests.Keys.cs

bartonjs · 2025-03-20T18:53:36Z

src/libraries/Common/tests/System/Security/Cryptography/MLKemTests.Keys.cs

+        [ConditionalFact(typeof(MLKem), nameof(MLKem.IsSupported))]
+        public static void ExportPrivateSeed_OnlyHasDecapsulationKey()
+        {
+            MLKemGenerateTestVector vector = MLKemGenerateTestVectors.First();
+            using MLKem kem = MLKem.ImportDecapsulationKey(
+                vector.Algorithm,
+                vector.DecapsulationKey.HexToByteArray());
+
+            Assert.Throws<CryptographicException>(() => kem.ExportPrivateSeed(
+                new byte[MLKem.PrivateSeedSizeInBytes]));
+        }


Maybe we'll have it later, but a template method boundary conditions test could import a decaps key (and/or encaps key) then call export on the seed with the wrong size, and we show that ExportPrivateSeedCore never got called.

I will add this to my scenario of "test cases when we have derived types" where "derived type = stub"

src/libraries/Common/tests/System/Security/Cryptography/MLKemTests.Keys.cs

...System.Security.Cryptography/src/System/Security/Cryptography/MLKemImplementation.OpenSsl.cs

src/native/libs/System.Security.Cryptography.Native/osslcompat_30.h

src/native/libs/System.Security.Cryptography.Native/pal_evp_kem.c

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.c

src/native/libs/System.Security.Cryptography.Native/osslcompat_30.h

bartonjs

So long as that one header uses a style consistently, LGTM

vcsjones added 26 commits March 18, 2025 09:52

Initial scaffolding and algorithm fetching

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

ebb5a1a

Key generation

122010a

Allow importing seeds into ML-KEM

e541327

Encapsulate

b3dd3ba

Public fields. Maybe a good idea

dc93837

Export decapsulation key

b421b4a

Export encaps key

8e603a3

NIST vectors for generation

50e57db

Minor tweaks

dfdb8e4

Round trip on encapsulation and decapsulation

8400cea

Reorder

d1d6b68

Merge remote-tracking branch 'ms/main' into ml-kem

cc76d55

Rework some key import and export things

5c69aa3

Encapsulation roundtrip

a6670c1

Import Decapsulation key

3e56b46

Check encapsulation key

6d568d7

More tests and resource strings

da5b60d

Keep working on tests

f9aa1be

Actual encapsulation tests

90b0ac5

Get tests building in OOB

5a36083

Improve test execution time

c647045

Remove redundant MLKem from member names

970c144

Add tests for MLKemAlgorithm

f0a8ea0

Test and prohibit overlapping buffers

0b6d963

Fixup docs

ff75b39

Fix doc contents

Loading
Loading status checks…

dc96bae

vcsjones requested review from bartonjs and Copilot March 20, 2025 01:13

dotnet-issue-labeler bot added area-System.Security new-api-needs-documentation labels Mar 20, 2025

Code review feedback.

Loading
Loading status checks…

5df8232

krwq reviewed Mar 20, 2025

View reviewed changes

...libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EVP.KemAlgs.cs Show resolved Hide resolved

This was referenced Mar 20, 2025

[wasm][AOT] emcc : error - received SIGKILL (-9) #89402

Open

SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449

Open

vcsjones commented Mar 20, 2025

View reviewed changes

Fix typos.

Loading
Loading status checks…

fe5a6ad