[cDAC] Resolve breaking change caused by removing ThunkHeap descriptor #113737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adapts the cDAC API to match recent changes in the DAC API by removing the ThunkHeap descriptor.
- Removed ThunkHeap field and property from Module.cs
- Removed the ILoader.GetThunkHeap method from Loader_1.cs
- Updated test descriptors in MockDescriptors.cs to remove the ThunkHeap definition
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Module.cs | Removed the ThunkHeap initialization and property as per the new DAC API |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs | Removed the ILoader.GetThunkHeap method which was no longer needed |
| src/native/managed/cdacreader/tests/MockDescriptors/MockDescriptors.cs | Removed the ThunkHeap descriptor from the type field definitions for consistency with the updated API |
|
Tagging subscribers to this area: @tommcdon |
added 2 commits
March 20, 2025 13:21
This was referenced Mar 20, 2025
jkotas
approved these changes
Mar 20, 2025
jkotas
reviewed
Mar 20, 2025
jkotas
reviewed
Mar 20, 2025
This was referenced Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112460 removed
m_pThunkHeapfromModuleand the associated datadescriptor.This value is used in a single DAC api which was changed in the same PR.
Modified cDAC api to match new DAC api.
This is a breaking change and could be fixed with a new contract version. However, I think we can ignore this field given the cDAC hasn't really shipped yet.