Skip to content

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Apr 2, 2025

No description provided.

@thaystg thaystg requested review from janvorli and Copilot April 2, 2025 20:36
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes line ending issues in the test file for IncreaseMetadataRowSize, ensuring consistent formatting.

  • Normalize line endings across the file
Files not reviewed (2)
  • src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize.csproj: Language not supported
  • src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/IncreaseMetadataRowSize_v1.cs: File too large

@am11 am11 added area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 2, 2025
@filipnavara
Copy link
Member

Thanks! Git on Windows really chokes hard on this and ends up in a state where I cannot switch branches.

@am11
Copy link
Member

am11 commented Apr 2, 2025

Ideally .gitattributes should enforce this if we add *.cs text eol=lf after:

*.sh text eol=lf
unless some .cs files deliberately have CRLF?

@janvorli janvorli merged commit 5d51698 into dotnet:main Apr 2, 2025
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants